d3vyce/taskiq-deduplication
1
0
Fork 0
mirror of https://github.com/d3vyce/taskiq-deduplication.git synced 2026-08-04 19:14:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: close leaked Redis clients on failed startup retries (#43)

Browse Source
This commit is contained in:
d3vyce
2026-06-02 18:56:57 +02:00
committed by GitHub
parent e253096236
commit db6e2b9715
2 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_middleware.py
+40
View File
@@ -455,6 +455,46 @@ class TestStartupRetry:
assert mock_sleep.call_args_list[0].args[0] == 0.01
assert mock_sleep.call_args_list[1].args[0] == 0.02
@pytest.mark.anyio
async def test_startup_closes_failed_clients(self):
mw = RedisDeduplicationMiddleware(
redis_url="redis://localhost",
startup_retries=3,
startup_retry_delay=0.01,
)
failed1, failed2, good = AsyncMock(), AsyncMock(), AsyncMock()
failed1.ping.side_effect = ConnectionError("fail")
failed2.ping.side_effect = ConnectionError("fail")
good.register_script = MagicMock()
with patch(
"redis.asyncio.Redis.from_url", side_effect=[failed1, failed2, good]
):
await mw.startup()
failed1.aclose.assert_called_once()
failed2.aclose.assert_called_once()
good.aclose.assert_not_called()
assert mw._redis is good
@pytest.mark.anyio
async def test_startup_closes_client_when_all_retries_exhausted(self):
mw = RedisDeduplicationMiddleware(
redis_url="redis://localhost",
startup_retries=2,
startup_retry_delay=0.01,
)
failed1, failed2 = AsyncMock(), AsyncMock()
failed1.ping.side_effect = ConnectionError("fail")
failed2.ping.side_effect = ConnectionError("fail")
with patch("redis.asyncio.Redis.from_url", side_effect=[failed1, failed2]):
with pytest.raises(ConnectionError):
await mw.startup()
failed1.aclose.assert_called_once()
failed2.aclose.assert_called_once()
class TestLabelTypeParsing:
@pytest.mark.anyio