mirror of
https://github.com/d3vyce/fastapi-toolsets.git
synced 2026-08-04 15:44:09 +00:00
Version 4.0.0 (#263)
* fix: lock_tables acquires dedicated session to enforce RAII lock boundaries (#261) * fix: make lock_tables generic over session type (#270) * docs: fix zensical warnings * Version 4.0.0 * docs: add v4 migration + fix lock_tables documentation
This commit is contained in:
@@ -130,7 +130,7 @@ Pass `next_cursor` as the `cursor` query parameter on the next request to advanc
|
|||||||
|
|
||||||
!!! info "Added in `v2.3.0`"
|
!!! info "Added in `v2.3.0`"
|
||||||
|
|
||||||
[`paginate()`](../module/crud.md#unified-paginate--both-strategies-on-one-endpoint) lets a single endpoint support both strategies via a `pagination_type` query parameter. The `pagination_type` field in the response acts as a discriminator for frontend tooling.
|
[`paginate()`](../module/crud.md#unified-endpoint-both-strategies) lets a single endpoint support both strategies via a `pagination_type` query parameter. The `pagination_type` field in the response acts as a discriminator for frontend tooling.
|
||||||
|
|
||||||
```python title="routes.py:61:79"
|
```python title="routes.py:61:79"
|
||||||
--8<-- "docs_src/examples/pagination_search/routes.py:61:79"
|
--8<-- "docs_src/examples/pagination_search/routes.py:61:79"
|
||||||
|
|||||||
@@ -0,0 +1,40 @@
|
|||||||
|
# Migrating to v4.0
|
||||||
|
|
||||||
|
This page covers every breaking change introduced in **v4.0** and the steps required to update your code.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Database
|
||||||
|
|
||||||
|
### `lock_tables` now takes a `session_maker` instead of a `session`
|
||||||
|
|
||||||
|
The first argument of `lock_tables` changed from an `AsyncSession` instance to an `async_sessionmaker`.
|
||||||
|
The function creates and manages its own **dedicated session** internally, yielding it to the caller.
|
||||||
|
|
||||||
|
=== "Before (`v3`)"
|
||||||
|
|
||||||
|
```python
|
||||||
|
from fastapi_toolsets.db import lock_tables, LockMode
|
||||||
|
|
||||||
|
async with lock_tables(session=session, tables=[User, Account]):
|
||||||
|
user = await UserCrud.get(session, [User.id == 1])
|
||||||
|
user.balance += 100
|
||||||
|
|
||||||
|
# With a custom lock mode
|
||||||
|
async with lock_tables(session, [Order], mode=LockMode.EXCLUSIVE):
|
||||||
|
await process_order(session, order_id)
|
||||||
|
```
|
||||||
|
|
||||||
|
=== "Now (`v4`)"
|
||||||
|
|
||||||
|
```python
|
||||||
|
from fastapi_toolsets.db import lock_tables, LockMode
|
||||||
|
|
||||||
|
async with lock_tables(session_maker=session_maker, tables=[User, Account]) as session:
|
||||||
|
user = await UserCrud.get(session, [User.id == 1])
|
||||||
|
user.balance += 100
|
||||||
|
|
||||||
|
# With a custom lock mode
|
||||||
|
async with lock_tables(session_maker, [Order], mode=LockMode.EXCLUSIVE) as session:
|
||||||
|
await process_order(session, order_id)
|
||||||
|
```
|
||||||
+4
-4
@@ -57,12 +57,12 @@ async def create_user_with_role(session=session):
|
|||||||
|
|
||||||
## Table locking
|
## Table locking
|
||||||
|
|
||||||
[`lock_tables`](../reference/db.md#fastapi_toolsets.db.lock_tables) acquires PostgreSQL table-level locks before executing critical sections:
|
[`lock_tables`](../reference/db.md#fastapi_toolsets.db.lock_tables) acquires PostgreSQL table-level locks before executing critical sections. It opens a **dedicated session** internally and yields it to the caller, so the lock is guaranteed to be released when the context exits:
|
||||||
|
|
||||||
```python
|
```python
|
||||||
from fastapi_toolsets.db import lock_tables
|
from fastapi_toolsets.db import lock_tables, LockMode
|
||||||
|
|
||||||
async with lock_tables(session=session, tables=[User], mode="EXCLUSIVE"):
|
async with lock_tables(session_maker=session_maker, tables=[User], mode=LockMode.EXCLUSIVE) as session:
|
||||||
# No other transaction can modify User until this block exits
|
# No other transaction can modify User until this block exits
|
||||||
...
|
...
|
||||||
```
|
```
|
||||||
@@ -129,7 +129,7 @@ SQLAlchemy's ORM collection API triggers lazy-loads when you append to a relatio
|
|||||||
```python
|
```python
|
||||||
from fastapi_toolsets.db import lock_tables, m2m_add
|
from fastapi_toolsets.db import lock_tables, m2m_add
|
||||||
|
|
||||||
async with lock_tables(session, [Tag]):
|
async with lock_tables(session_maker, [Tag]) as session:
|
||||||
tag = await TagCrud.create(session, TagCreate(name="python"))
|
tag = await TagCrud.create(session, TagCreate(name="python"))
|
||||||
await m2m_add(session, post, Post.tags, tag)
|
await m2m_add(session, post, Post.tags, tag)
|
||||||
```
|
```
|
||||||
|
|||||||
@@ -102,7 +102,7 @@ async def list_events(
|
|||||||
|
|
||||||
#### [`PaginatedResponse[T]`](../reference/schemas.md#fastapi_toolsets.schemas.PaginatedResponse)
|
#### [`PaginatedResponse[T]`](../reference/schemas.md#fastapi_toolsets.schemas.PaginatedResponse)
|
||||||
|
|
||||||
Return type for endpoints that support **both** pagination strategies via a `pagination_type` query parameter (using [`paginate()`](crud.md#unified-paginate--both-strategies-on-one-endpoint)).
|
Return type for endpoints that support **both** pagination strategies via a `pagination_type` query parameter (using [`paginate()`](crud.md#unified-endpoint-both-strategies)).
|
||||||
|
|
||||||
When used as a return annotation, `PaginatedResponse[T]` automatically expands to `Annotated[Union[CursorPaginatedResponse[T], OffsetPaginatedResponse[T]], Field(discriminator="pagination_type")]`, so FastAPI emits a proper `oneOf` + discriminator in the OpenAPI schema with no extra boilerplate:
|
When used as a return annotation, `PaginatedResponse[T]` automatically expands to `Annotated[Union[CursorPaginatedResponse[T], OffsetPaginatedResponse[T]], Field(discriminator="pagination_type")]`, so FastAPI emits a proper `oneOf` + discriminator in the OpenAPI schema with no extra boilerplate:
|
||||||
|
|
||||||
@@ -129,7 +129,7 @@ async def list_users(
|
|||||||
|
|
||||||
#### Pagination metadata models
|
#### Pagination metadata models
|
||||||
|
|
||||||
The optional `filter_attributes` field is populated when `facet_fields` are configured on the CRUD class (see [Filter attributes](crud.md#filter-attributes-facets)). It is `None` by default and can be hidden from API responses with `response_model_exclude_none=True`.
|
The optional `filter_attributes` field is populated when `facet_fields` are configured on the CRUD class (see [Filter attributes](crud.md#faceted-search)). It is `None` by default and can be hidden from API responses with `response_model_exclude_none=True`.
|
||||||
|
|
||||||
### [`ErrorResponse`](../reference/schemas.md#fastapi_toolsets.schemas.ErrorResponse)
|
### [`ErrorResponse`](../reference/schemas.md#fastapi_toolsets.schemas.ErrorResponse)
|
||||||
|
|
||||||
|
|||||||
@@ -12,6 +12,7 @@ from fastapi_toolsets.exceptions import (
|
|||||||
NotFoundError,
|
NotFoundError,
|
||||||
ConflictError,
|
ConflictError,
|
||||||
NoSearchableFieldsError,
|
NoSearchableFieldsError,
|
||||||
|
InvalidSearchColumnError,
|
||||||
InvalidFacetFilterError,
|
InvalidFacetFilterError,
|
||||||
InvalidOrderFieldError,
|
InvalidOrderFieldError,
|
||||||
generate_error_responses,
|
generate_error_responses,
|
||||||
@@ -31,6 +32,8 @@ from fastapi_toolsets.exceptions import (
|
|||||||
|
|
||||||
## ::: fastapi_toolsets.exceptions.exceptions.NoSearchableFieldsError
|
## ::: fastapi_toolsets.exceptions.exceptions.NoSearchableFieldsError
|
||||||
|
|
||||||
|
## ::: fastapi_toolsets.exceptions.exceptions.InvalidSearchColumnError
|
||||||
|
|
||||||
## ::: fastapi_toolsets.exceptions.exceptions.InvalidFacetFilterError
|
## ::: fastapi_toolsets.exceptions.exceptions.InvalidFacetFilterError
|
||||||
|
|
||||||
## ::: fastapi_toolsets.exceptions.exceptions.InvalidOrderFieldError
|
## ::: fastapi_toolsets.exceptions.exceptions.InvalidOrderFieldError
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
[project]
|
[project]
|
||||||
name = "fastapi-toolsets"
|
name = "fastapi-toolsets"
|
||||||
version = "3.1.1"
|
version = "4.0.0"
|
||||||
description = "Production-ready utilities for FastAPI applications"
|
description = "Production-ready utilities for FastAPI applications"
|
||||||
readme = "README.md"
|
readme = "README.md"
|
||||||
license = "MIT"
|
license = "MIT"
|
||||||
|
|||||||
@@ -21,4 +21,4 @@ Example usage:
|
|||||||
return Response(data={"user": user.username}, message="Success")
|
return Response(data={"user": user.username}, message="Success")
|
||||||
"""
|
"""
|
||||||
|
|
||||||
__version__ = "3.1.1"
|
__version__ = "4.0.0"
|
||||||
|
|||||||
+26
-21
@@ -151,52 +151,57 @@ class LockMode(str, Enum):
|
|||||||
ACCESS_EXCLUSIVE = "ACCESS EXCLUSIVE"
|
ACCESS_EXCLUSIVE = "ACCESS EXCLUSIVE"
|
||||||
|
|
||||||
|
|
||||||
@asynccontextmanager
|
def lock_tables(
|
||||||
async def lock_tables(
|
session_maker: async_sessionmaker[_SessionT],
|
||||||
session: AsyncSession,
|
|
||||||
tables: list[type[DeclarativeBase]],
|
tables: list[type[DeclarativeBase]],
|
||||||
*,
|
*,
|
||||||
mode: LockMode = LockMode.SHARE_UPDATE_EXCLUSIVE,
|
mode: LockMode = LockMode.SHARE_UPDATE_EXCLUSIVE,
|
||||||
timeout: str = "5s",
|
timeout: str = "5s",
|
||||||
) -> AsyncGenerator[AsyncSession, None]:
|
) -> AbstractAsyncContextManager[_SessionT]:
|
||||||
"""Lock PostgreSQL tables for the duration of a transaction.
|
"""Lock PostgreSQL tables for the duration of a transaction.
|
||||||
|
|
||||||
Acquires table-level locks that are held until the transaction ends.
|
|
||||||
Useful for preventing concurrent modifications during critical operations.
|
|
||||||
|
|
||||||
Args:
|
Args:
|
||||||
session: AsyncSession instance
|
session_maker: Async session factory used to create the dedicated
|
||||||
tables: List of SQLAlchemy model classes to lock
|
session.
|
||||||
mode: Lock mode (default: SHARE UPDATE EXCLUSIVE)
|
tables: List of SQLAlchemy model classes to lock.
|
||||||
timeout: Lock timeout (default: "5s")
|
mode: Lock mode (default: SHARE UPDATE EXCLUSIVE).
|
||||||
|
timeout: Lock timeout (default: "5s").
|
||||||
|
|
||||||
Yields:
|
Yields:
|
||||||
The session with locked tables
|
The dedicated session, open within the locked transaction.
|
||||||
|
|
||||||
Raises:
|
Raises:
|
||||||
SQLAlchemyError: If lock cannot be acquired within timeout
|
SQLAlchemyError: If the lock cannot be acquired within *timeout*.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
```python
|
```python
|
||||||
from fastapi_toolsets.db import lock_tables, LockMode
|
from fastapi_toolsets.db import lock_tables, LockMode
|
||||||
|
|
||||||
async with lock_tables(session, [User, Account]):
|
async with lock_tables(session_maker, [User, Account]) as session:
|
||||||
# Tables are locked with SHARE UPDATE EXCLUSIVE mode
|
# Tables are locked; changes are committed when the context exits.
|
||||||
user = await UserCrud.get(session, [User.id == 1])
|
user = await UserCrud.get(session, [User.id == 1])
|
||||||
user.balance += 100
|
user.balance += 100
|
||||||
|
|
||||||
# With custom lock mode
|
# With custom lock mode
|
||||||
async with lock_tables(session, [Order], mode=LockMode.EXCLUSIVE):
|
async with lock_tables(session_maker, [Order], mode=LockMode.EXCLUSIVE) as session:
|
||||||
# Exclusive lock - no other transactions can access
|
|
||||||
await process_order(session, order_id)
|
await process_order(session, order_id)
|
||||||
```
|
```
|
||||||
"""
|
"""
|
||||||
table_names = ",".join(table.__tablename__ for table in tables)
|
table_names = ",".join(table.__tablename__ for table in tables)
|
||||||
|
|
||||||
async with get_transaction(session):
|
@asynccontextmanager
|
||||||
await session.execute(text(f"SET LOCAL lock_timeout='{timeout}'"))
|
async def _lock() -> AsyncGenerator[_SessionT, None]:
|
||||||
await session.execute(text(f"LOCK {table_names} IN {mode.value} MODE"))
|
async with session_maker() as session:
|
||||||
yield session
|
try:
|
||||||
|
await session.execute(text(f"SET LOCAL lock_timeout='{timeout}'"))
|
||||||
|
await session.execute(text(f"LOCK {table_names} IN {mode.value} MODE"))
|
||||||
|
yield session
|
||||||
|
await session.commit()
|
||||||
|
except BaseException:
|
||||||
|
await session.rollback()
|
||||||
|
raise
|
||||||
|
|
||||||
|
return _lock()
|
||||||
|
|
||||||
|
|
||||||
async def create_database(
|
async def create_database(
|
||||||
|
|||||||
@@ -439,6 +439,21 @@ async def engine():
|
|||||||
await engine.dispose()
|
await engine.dispose()
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(scope="function")
|
||||||
|
async def session_maker(engine):
|
||||||
|
"""Provide a session factory with tables created and dropped around the test."""
|
||||||
|
async with engine.begin() as conn:
|
||||||
|
await conn.run_sync(Base.metadata.create_all)
|
||||||
|
|
||||||
|
factory = async_sessionmaker(engine, expire_on_commit=False)
|
||||||
|
|
||||||
|
try:
|
||||||
|
yield factory
|
||||||
|
finally:
|
||||||
|
async with engine.begin() as conn:
|
||||||
|
await conn.run_sync(Base.metadata.drop_all)
|
||||||
|
|
||||||
|
|
||||||
@pytest.fixture(scope="function")
|
@pytest.fixture(scope="function")
|
||||||
async def db_session(engine):
|
async def db_session(engine):
|
||||||
"""Create a test database session with tables.
|
"""Create a test database session with tables.
|
||||||
|
|||||||
+52
-64
@@ -116,13 +116,8 @@ class TestCreateDbDependency:
|
|||||||
await engine.dispose()
|
await engine.dispose()
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_update_after_lock_tables_is_persisted(self):
|
async def test_data_inside_lock_is_committed(self):
|
||||||
"""Changes made after lock_tables exits (before endpoint returns) are committed.
|
"""Changes made inside lock_tables are committed when the context exits."""
|
||||||
|
|
||||||
Regression: without the auto-begin fix, lock_tables would start and commit a
|
|
||||||
real outer transaction, leaving the session idle. Any modifications after that
|
|
||||||
point were silently dropped.
|
|
||||||
"""
|
|
||||||
engine = create_async_engine(DATABASE_URL, echo=False)
|
engine = create_async_engine(DATABASE_URL, echo=False)
|
||||||
session_factory = async_sessionmaker(engine, expire_on_commit=False)
|
session_factory = async_sessionmaker(engine, expire_on_commit=False)
|
||||||
|
|
||||||
@@ -130,21 +125,12 @@ class TestCreateDbDependency:
|
|||||||
await conn.run_sync(Base.metadata.create_all)
|
await conn.run_sync(Base.metadata.create_all)
|
||||||
|
|
||||||
try:
|
try:
|
||||||
get_db = create_db_dependency(session_factory)
|
async with lock_tables(session_factory, [Role]) as session:
|
||||||
|
role = Role(name="lock_committed")
|
||||||
async for session in get_db():
|
session.add(role)
|
||||||
async with lock_tables(session, [Role]):
|
|
||||||
role = Role(name="lock_then_update")
|
|
||||||
session.add(role)
|
|
||||||
await session.flush()
|
|
||||||
# lock_tables has exited — outer transaction must still be open
|
|
||||||
assert session.in_transaction()
|
|
||||||
role.name = "updated_after_lock"
|
|
||||||
|
|
||||||
async with session_factory() as verify:
|
async with session_factory() as verify:
|
||||||
result = await RoleCrud.first(
|
result = await RoleCrud.first(verify, [Role.name == "lock_committed"])
|
||||||
verify, [Role.name == "updated_after_lock"]
|
|
||||||
)
|
|
||||||
assert result is not None
|
assert result is not None
|
||||||
finally:
|
finally:
|
||||||
async with engine.begin() as conn:
|
async with engine.begin() as conn:
|
||||||
@@ -287,54 +273,55 @@ class TestLockTables:
|
|||||||
"""Tests for lock_tables context manager (PostgreSQL-specific)."""
|
"""Tests for lock_tables context manager (PostgreSQL-specific)."""
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_lock_single_table(self, db_session: AsyncSession):
|
async def test_lock_single_table(self, session_maker):
|
||||||
"""Lock a single table."""
|
"""Lock a single table; changes inside are committed on context exit."""
|
||||||
async with lock_tables(db_session, [Role]):
|
async with lock_tables(session_maker, [Role]) as session:
|
||||||
# Inside the lock, we can still perform operations
|
|
||||||
role = Role(name="locked_role")
|
role = Role(name="locked_role")
|
||||||
db_session.add(role)
|
session.add(role)
|
||||||
await db_session.flush()
|
|
||||||
|
|
||||||
# After lock is released, verify the data was committed
|
async with session_maker() as verify:
|
||||||
result = await RoleCrud.first(db_session, [Role.name == "locked_role"])
|
result = await RoleCrud.first(verify, [Role.name == "locked_role"])
|
||||||
assert result is not None
|
assert result is not None
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_lock_multiple_tables(self, db_session: AsyncSession):
|
async def test_lock_multiple_tables(self, session_maker):
|
||||||
"""Lock multiple tables."""
|
"""Lock multiple tables."""
|
||||||
async with lock_tables(db_session, [Role, User]):
|
async with lock_tables(session_maker, [Role, User]) as session:
|
||||||
role = Role(name="multi_lock_role")
|
role = Role(name="multi_lock_role")
|
||||||
db_session.add(role)
|
session.add(role)
|
||||||
await db_session.flush()
|
|
||||||
|
|
||||||
result = await RoleCrud.first(db_session, [Role.name == "multi_lock_role"])
|
async with session_maker() as verify:
|
||||||
assert result is not None
|
result = await RoleCrud.first(verify, [Role.name == "multi_lock_role"])
|
||||||
|
assert result is not None
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_lock_with_custom_mode(self, db_session: AsyncSession):
|
async def test_lock_with_custom_mode(self, session_maker):
|
||||||
"""Lock with custom lock mode."""
|
"""Lock with custom lock mode."""
|
||||||
async with lock_tables(db_session, [Role], mode=LockMode.EXCLUSIVE):
|
async with lock_tables(
|
||||||
|
session_maker, [Role], mode=LockMode.EXCLUSIVE
|
||||||
|
) as session:
|
||||||
role = Role(name="exclusive_lock_role")
|
role = Role(name="exclusive_lock_role")
|
||||||
db_session.add(role)
|
session.add(role)
|
||||||
await db_session.flush()
|
|
||||||
|
|
||||||
result = await RoleCrud.first(db_session, [Role.name == "exclusive_lock_role"])
|
async with session_maker() as verify:
|
||||||
assert result is not None
|
result = await RoleCrud.first(verify, [Role.name == "exclusive_lock_role"])
|
||||||
|
assert result is not None
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_lock_rollback_on_exception(self, db_session: AsyncSession):
|
async def test_lock_rollback_on_exception(self, session_maker):
|
||||||
"""Lock context rolls back on exception."""
|
"""Lock context rolls back on exception."""
|
||||||
try:
|
try:
|
||||||
async with lock_tables(db_session, [Role]):
|
async with lock_tables(session_maker, [Role]) as session:
|
||||||
role = Role(name="lock_rollback_role")
|
role = Role(name="lock_rollback_role")
|
||||||
db_session.add(role)
|
session.add(role)
|
||||||
await db_session.flush()
|
await session.flush()
|
||||||
raise ValueError("Simulated error")
|
raise ValueError("Simulated error")
|
||||||
except ValueError:
|
except ValueError:
|
||||||
pass
|
pass
|
||||||
|
|
||||||
result = await RoleCrud.first(db_session, [Role.name == "lock_rollback_role"])
|
async with session_maker() as verify:
|
||||||
assert result is None
|
result = await RoleCrud.first(verify, [Role.name == "lock_rollback_role"])
|
||||||
|
assert result is None
|
||||||
|
|
||||||
|
|
||||||
class TestWaitForRowChange:
|
class TestWaitForRowChange:
|
||||||
@@ -643,29 +630,30 @@ class TestM2MAdd:
|
|||||||
await m2m_add(db_session, user, User.role, role)
|
await m2m_add(db_session, user, User.role, role)
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_works_inside_lock_tables(self, db_session: AsyncSession):
|
async def test_works_inside_lock_tables(self, session_maker):
|
||||||
"""m2m_add works correctly inside a lock_tables nested transaction."""
|
"""m2m_add works correctly inside a lock_tables context."""
|
||||||
user = User(username="m2m_lock_author", email="m2m_lock@test.com")
|
async with lock_tables(session_maker, [Tag]) as session:
|
||||||
db_session.add(user)
|
user = User(username="m2m_lock_author", email="m2m_lock@test.com")
|
||||||
await db_session.flush()
|
session.add(user)
|
||||||
|
await session.flush()
|
||||||
|
|
||||||
async with lock_tables(db_session, [Tag]):
|
|
||||||
tag = Tag(name="locked_tag")
|
tag = Tag(name="locked_tag")
|
||||||
db_session.add(tag)
|
session.add(tag)
|
||||||
await db_session.flush()
|
await session.flush()
|
||||||
|
|
||||||
post = Post(title="Post Lock", author_id=user.id)
|
post = Post(title="Post Lock", author_id=user.id)
|
||||||
db_session.add(post)
|
session.add(post)
|
||||||
await db_session.flush()
|
await session.flush()
|
||||||
|
|
||||||
await m2m_add(db_session, post, Post.tags, tag)
|
await m2m_add(session, post, Post.tags, tag)
|
||||||
|
|
||||||
result = await db_session.execute(
|
async with session_maker() as verify:
|
||||||
select(Post).where(Post.id == post.id).options(selectinload(Post.tags))
|
result = await verify.execute(
|
||||||
)
|
select(Post).where(Post.id == post.id).options(selectinload(Post.tags))
|
||||||
loaded = result.scalar_one()
|
)
|
||||||
assert len(loaded.tags) == 1
|
loaded = result.scalar_one()
|
||||||
assert loaded.tags[0].name == "locked_tag"
|
assert len(loaded.tags) == 1
|
||||||
|
assert loaded.tags[0].name == "locked_tag"
|
||||||
|
|
||||||
|
|
||||||
class _LocalBase(DeclarativeBase):
|
class _LocalBase(DeclarativeBase):
|
||||||
|
|||||||
+23
-6
@@ -7,6 +7,7 @@ from unittest.mock import patch
|
|||||||
|
|
||||||
import pytest
|
import pytest
|
||||||
from sqlalchemy import String
|
from sqlalchemy import String
|
||||||
|
from sqlalchemy.ext.asyncio import async_sessionmaker, create_async_engine
|
||||||
from sqlalchemy.orm import DeclarativeBase, Mapped, mapped_column
|
from sqlalchemy.orm import DeclarativeBase, Mapped, mapped_column
|
||||||
|
|
||||||
import fastapi_toolsets.models.watched as _watched_module
|
import fastapi_toolsets.models.watched as _watched_module
|
||||||
@@ -20,6 +21,7 @@ from fastapi_toolsets.models import (
|
|||||||
listens_for,
|
listens_for,
|
||||||
)
|
)
|
||||||
from fastapi_toolsets.models.watched import (
|
from fastapi_toolsets.models.watched import (
|
||||||
|
EventSession,
|
||||||
_EVENT_HANDLERS,
|
_EVENT_HANDLERS,
|
||||||
_SESSION_CREATES,
|
_SESSION_CREATES,
|
||||||
_SESSION_DELETES,
|
_SESSION_DELETES,
|
||||||
@@ -338,6 +340,23 @@ async def mixin_session_expire():
|
|||||||
yield session
|
yield session
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture(scope="function")
|
||||||
|
async def mixin_session_maker():
|
||||||
|
"""Provide an EventSession-backed session factory with MixinBase tables."""
|
||||||
|
engine = create_async_engine(DATABASE_URL, echo=False)
|
||||||
|
async with engine.begin() as conn:
|
||||||
|
await conn.run_sync(MixinBase.metadata.create_all)
|
||||||
|
|
||||||
|
factory = async_sessionmaker(engine, expire_on_commit=False, class_=EventSession)
|
||||||
|
|
||||||
|
try:
|
||||||
|
yield factory
|
||||||
|
finally:
|
||||||
|
async with engine.begin() as conn:
|
||||||
|
await conn.run_sync(MixinBase.metadata.drop_all)
|
||||||
|
await engine.dispose()
|
||||||
|
|
||||||
|
|
||||||
class TestUUIDMixin:
|
class TestUUIDMixin:
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_uuid_generated_by_db(self, mixin_session):
|
async def test_uuid_generated_by_db(self, mixin_session):
|
||||||
@@ -1559,15 +1578,13 @@ class TestEventSessionWithGetTransaction:
|
|||||||
assert creates[0]["obj_id"] == survivor.id
|
assert creates[0]["obj_id"] == survivor.id
|
||||||
|
|
||||||
@pytest.mark.anyio
|
@pytest.mark.anyio
|
||||||
async def test_lock_tables_with_events(self, mixin_session):
|
async def test_lock_tables_with_events(self, mixin_session_maker):
|
||||||
"""Events fire correctly after lock_tables context."""
|
"""Events fire correctly when lock_tables commits on context exit."""
|
||||||
from fastapi_toolsets.db import lock_tables
|
from fastapi_toolsets.db import lock_tables
|
||||||
|
|
||||||
async with lock_tables(mixin_session, [WatchedModel]):
|
async with lock_tables(mixin_session_maker, [WatchedModel]) as session:
|
||||||
obj = WatchedModel(status="locked", other="x")
|
obj = WatchedModel(status="locked", other="x")
|
||||||
mixin_session.add(obj)
|
session.add(obj)
|
||||||
|
|
||||||
await mixin_session.commit()
|
|
||||||
|
|
||||||
creates = [e for e in _test_events if e["event"] == "create"]
|
creates = [e for e in _test_events if e["event"] == "create"]
|
||||||
assert len(creates) == 1
|
assert len(creates) == 1
|
||||||
|
|||||||
@@ -330,7 +330,7 @@ wheels = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "fastapi-toolsets"
|
name = "fastapi-toolsets"
|
||||||
version = "3.1.1"
|
version = "4.0.0"
|
||||||
source = { editable = "." }
|
source = { editable = "." }
|
||||||
dependencies = [
|
dependencies = [
|
||||||
{ name = "asyncpg" },
|
{ name = "asyncpg" },
|
||||||
|
|||||||
@@ -147,6 +147,7 @@ Examples = [
|
|||||||
|
|
||||||
[[project.nav]]
|
[[project.nav]]
|
||||||
Migration = [
|
Migration = [
|
||||||
|
{"v4.0" = "migration/v4.md"},
|
||||||
{"v3.0" = "migration/v3.md"},
|
{"v3.0" = "migration/v3.md"},
|
||||||
{"v2.0" = "migration/v2.md"},
|
{"v2.0" = "migration/v2.md"},
|
||||||
]
|
]
|
||||||
|
|||||||
Reference in New Issue
Block a user